[PATCH] D122748: [Sema] Don't check bounds for function pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2c3ae0b6f05: [Sema] Don't check bounds for function pointer (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://review

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. >> Friendly ping Unfriendly LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 _

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. Friendly ping. In D122748#3417500 , @erichkeane wrote: > would still like to see the feedback from the original submitter here to see > if there is more work to do in here that would be valuable. Unsure, maybe we can process w

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane added a comment. I think I'm generally in favor, would still like to see the feedback from the original submitter here to see if there is more work to do in here that would be valuable. Comment at: clang/lib/Sema/SemaChecking.cpp:15471 if (IsUnboundedArray) { +

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. In D122748#3417240 , @erichkeane wrote: > That said, we might not want to early-exist here, I think we can just skip > the `IsUnboundedArray` branch? It seems you are right, thanks, fixed. Repository: rG LLVM Github Monorep

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX updated this revision to Diff 419242. ArcsinX added a comment. Check for function type only if IsUnboundedArray is true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 Files: clang/lib/Sema/Sema

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane added a comment. It seems like this entire section of code was added here: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a @chrish_ericsson_atx should probably take a look at this. That said, we might not want to early-exist here, I think we can

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, erichkeane, abhinavgaba, chrish_ericsson_atx. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang crashes with i386 ta