[PATCH] D122586: Fix template instantiation of UDLs

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in ca844ab01c3f9410ceca967c09f809400950beae . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122586/new/ https://re

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin accepted this revision. cor3ntin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee())

[PATCH] D122586: Fix template instantiation of UDLs

aaron.ballman updated this revision to Diff 418650. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Update based on review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122586/new/ https://reviews.llvm.org/D122586 Files: clang/docs/ReleaseNotes

[PATCH] D122586: Fix template instantiation of UDLs

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.May

[PATCH] D122586: Fix template instantiation of UDLs

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.Maybe

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp:28 + +namespace Issue54578 { +inline consteval unsigned char operator""_UC(const unsigned long long n) {

[PATCH] D122586: Fix template instantiation of UDLs

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.May

[PATCH] D122586: Fix template instantiation of UDLs

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Previously, we would instantiate the UDL by marking the function as referenced an