[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

This revision was automatically updated to reflect the committed changes. Closed by commit rGd16a631c124f: [AVR] Merge AVRRelaxMemOperations into AVRExpandPseudoInsts (authored by Patryk27, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. In D122533#3410428 , @benshi001 wrote: > In D122533#3410259 , @Patryk27 > wrote: > >> Ok, I have added the switch; I think a separate patch that adds that switch >> to all of the AVR te

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410259 , @Patryk27 wrote: > Ok, I have added the switch; I think a separate patch that adds that switch > to all of the AVR tests could come handy - what do you think? No. `-verify-machineinstrs` might be default i

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. @aykevl How about your opinion? I think current form is good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.ll

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Ok, I have added the switch; I think a separate patch that adds that switch to all the tests would be handy - what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 updated this revision to Diff 418460. Patryk27 added a comment. Add `-verify-machineinstrs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 Files: clang/docs/tools/clang-formatted-files.txt l

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir:1 -# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s +# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s benshi001 wrote: > You can trigger

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Ah, nevermind - looks like I've already actually used `SUBIWRdK`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 ___ cfe-commits mail

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Ah, sorry - I've pushed my changes at the same time you created your comment; one moment, let me change to SUBIW, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 _

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 marked 2 inline comments as done. Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(Src

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 updated this revision to Diff 418443. Patryk27 added a comment. SBCI -> SUBI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 Files: clang/docs/tools/clang-formatted-files.txt llvm/lib/Target/

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410072 , @Patryk27 wrote: > I think I'm using `=Release` instead of `=Debug`, that would explain the > difference, yeah; You need not Debug, just add `-verify-machineinstrs` option after the `-run-pass=avr-expand-

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. I think I'm using `=Release` instead of `=Debug`, that would explain the difference, yeah; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 __

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir:1 -# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s +# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s You can trigger the bug, with `-ver

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +bu

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410064 , @Patryk27 wrote: > Hmm, that's weird - I've just re-checked and everything's working correctly > on my side; maybe you're testing it on an older LLVM revision? (for > reference, my patch is based off of th

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Hmm, that's weird - I've just re-checked and everything's working correctly on my side; maybe you're testing it on an older LLVM revision? (for reference, my patch is based off of the current LLVM's main branch, which - at the time of writing this comment - is the d9ce

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. I have built (with -DCMAKE_BUILD_TYPE=Debug) and tested your patch, but got the following failure FAIL: LLVM :: CodeGen/AVR/pseudo/STDWPtrQRr.mir (150 of 152) TEST 'LLVM :: CodeGen/AVR/pseudo/STDWPtrQRr.mir' FAILED Scrip

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a subscriber: benshi001. Patryk27 added a comment. cc @benshi001 (from https://reviews.llvm.org/D114611) 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 __

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 updated this revision to Diff 418413. Patryk27 retitled this revision from "[avr] Remove AVRRelaxMemOperations" to "[AVR] Remove AVRRelaxMemOperations". Patryk27 added a comment. avr -> AVR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122

[PATCH] D122533: [avr] Remove AVRRelaxMemOperations

Patryk27 created this revision. Herald added subscribers: Jim, hiraditya, mgorny, dylanmckay. Herald added a project: All. Patryk27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This commit contains a refactoring that me