[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-18 Thread sstwcw via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfee94803f59d: [clang-format] Copy help options to the doc directory. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https:/

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D121890#3389171 , @sstwcw wrote: > The issue is #54418. > > Actually I don't know who I should add as reviewers. The patches for > clang-format don't always seem to have the same reviewers. Who are the main > develop

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a subscriber: krasimir. owenpan added a comment. In D121890#3389171 , @sstwcw wrote: > The issue is #54418. > > Actually I don't know who I should add as reviewers. The patches for > clang-format don't always seem to have the same reviewer

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked an inline comment as done. sstwcw added a comment. The issue is #54418. Actually I don't know who I should add as reviewers. The patches for clang-format don't always seem to have the same reviewers. Who are the main developers and how do you decide who you add each time? I give

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. 1. Please log a github issue showing us what you are fixing. 2. Please add the main clang-formatter developers as reviewers and not the clang-format project (I think w

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread sstwcw via Phabricator via cfe-commits
sstwcw added inline comments. Comment at: clang/docs/ClangFormat.rst:76 +--output-replacements-xml - Output replacements as XML. +--qualifier-alignment= - If set, overrides the qualifier alignment style determined by the QualifierAlignment style flag +--sort-inc

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/docs/ClangFormat.rst:76 +--output-replacements-xml - Output replacements as XML. +--qualifier-alignment= - If set, overrides the qualifier alignment style determined by the QualifierAlignment style flag +--sort-i

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. If anyone's wondering why all the lines changed. The `--qualifier-alignment` is too long so all the descriptions are moved to the right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https://reviews.llvm.org/D1

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 416097. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https://reviews.llvm.org/D121890 Files: clang/docs/ClangFormat.rst Index: clang/docs/ClangFormat.rst ==

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

2022-03-17 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The options listed in ClangFormat.rst lag behind