jyknight closed this revision.
jyknight added a comment.
D'oh, I copy/pasted the wrong review link when submitting this. It was
submitted as http://reviews.llvm.org/rL245667.
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@l
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
lgtm
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
danalbert added inline comments.
Comment at: lib/Driver/Tools.cpp:3025
@@ -3024,3 +3024,3 @@
- // Note that these flags are trump-cards. Regardless of the order w.r.t. the
- // PIC or PIE options above, if these show up, PIC is disabled.
+ // Note that this flag is a trump-ca
jyknight created this revision.
jyknight added a reviewer: joerg.
jyknight added subscribers: rnk, jevinskie, tberghammer, danalbert, srhines,
cfe-commits.
For some reason, clang had been treating a command like:
clang -static -fPIC foo.c
as if it should be compiled without the PIC relocation mo
