This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0cdafe8d4b2: [AST] Better recovery on an expression refers
to an invalid decl. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121599/ne
hokein added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:1230
LookupResult Result(*this, Name, NameLoc, LookupOrdinaryName);
return BuildDeclarationNameExpr(SS, Result, /*ADL=*/true);
}
sammccall wrote:
> wonder if if the results of setting Ac
hokein updated this revision to Diff 462131.
hokein marked 3 inline comments as done.
hokein added a comment.
rebase and address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121599/new/
https://reviews.llvm.org/D121599
Files:
clang/li
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Diagnostic changes look great!
Comment at: clang/lib/Sema/SemaDecl.cpp:1230
LookupResult Result(*this, Name, NameLoc, LookupOrdinaryName);
return BuildDeclaration
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang.
Prior to the patch, we didn't build a DeclRefExpr if the Decl being
referred to is invalid, because many clang downstream AST cons
