[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

curdeius added a comment. In D121576#3381295 , @owenpan wrote: > Right. I think we should have a specification (including when not to align > the cells) and re-design the entire thing. It's not maintainable as is. I > have some ideas but need to remove/

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

MyDeveloperDay added a comment. Please do, to be honest I spent enough time on this and I got to the same conclusion, it needs a rethink. Please go ahead, I don't use this feature myself so I'm not likely to see all the issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan added a comment. In D121576#3378934 , @MyDeveloperDay wrote: > I'm wondering if the presence of the comment would impact the CellCount, I > might go back and add some more unit tests for the "non rectangular" change I > made. > > So this fixes

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a0cc3c58a74: [clang-format] Don't unwrap lines preceded by line comments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ h

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm wondering if the presence of the comment would impact the CellCount, I might go back and add some more unit tests for the "non rectangular" change I made. So this fixes the "}" going up onto the comment line, but not the

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan updated this revision to Diff 415031. owenpan added a comment. Reset the `Spaces` of the closing brace only if it can be unwrapped. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ https://reviews.llvm.org/D121576 Files: clang/lib/Format/WhitespaceManager.cpp clang

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ https://reviews.llvm.org/D121576 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://