Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-27 Thread David Blaikie via cfe-commits
On Tue, Aug 25, 2015 at 10:50 AM, Bataev, Alexey wrote: > Guys, talking about implicitly captured variables we have to deal with 2 > locations: 1) point of real capturing (it is the point of '=' or '&' > symbols in lambda capture-list); I'm not sure that's "the point of real capturing" if it's

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread Bataev, Alexey via cfe-commits
Guys, talking about implicitly captured variables we have to deal with 2 locations: 1) point of real capturing (it is the point of '=' or '&' symbols in lambda capture-list); 2) a point of first use of variable inside lambda's body. When we're talking about diagnostic for implicitly captured var

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread Eric Christopher via cfe-commits
Yeah. I can't see a difference here being useful, and more likely harmful. On Tue, Aug 25, 2015, 8:48 AM David Blaikie wrote: > On Tue, Aug 25, 2015 at 8:44 AM, Bataev, Alexey > wrote: > >> Debug info points to the real place where it is captured, while >> diagnostics points to the first use of

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread Bataev, Alexey via cfe-commits
Debug info points to the real place where it is captured, while diagnostics points to the first use of implicitly captured variable. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 25.08.2015 18:22, David Blaikie пишет: On Tue, Aug 25, 2015 at 8:18 AM, Bataev,

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread David Blaikie via cfe-commits
On Tue, Aug 25, 2015 at 8:44 AM, Bataev, Alexey wrote: > Debug info points to the real place where it is captured, while > diagnostics points to the first use of implicitly captured variable. Right, but I'm trying to understand the justification for why that's the right thing to do. Why the deb

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread David Blaikie via cfe-commits
On Tue, Aug 25, 2015 at 8:18 AM, Bataev, Alexey wrote: > I though about this. I think it will be more convenient for user to see > the diagnostic on the first use of the variable rather than on '=' or '&' > symbol. > Why the difference between the diagnostic & the debug info, then? > > Best re

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread Bataev, Alexey via cfe-commits
I though about this. I think it will be more convenient for user to see the diagnostic on the first use of the variable rather than on '=' or '&' symbol. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 25.08.2015 18:07, David Blaikie пишет: On Tue, Aug 18, 20

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-25 Thread David Blaikie via cfe-commits
On Tue, Aug 18, 2015 at 9:05 PM, Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ABataev created this revision. > ABataev added reviewers: echristo, rjmccall, rsmith. > ABataev added a subscriber: cfe-commits. > > When variables are implicitly captured in lambdas, debug info g

[PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

2015-08-18 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: echristo, rjmccall, rsmith. ABataev added a subscriber: cfe-commits. When variables are implicitly captured in lambdas, debug info generated for captured variables points to location where they are used first. This patch makes debug info t