[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18c84e2d325f: [clang][dataflow] Fix nullptr dereferencing error. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. Wonderful, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 ___ cfe-commits mailing list cfe

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D121158#3365494 , @ymandel wrote: > In D121158#3365415 , @xazax.hun > wrote: > >>> When pre-initializing fields in the environment, the code assumed that all >>> fields of a struct wo

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 413674. ymandel added a comment. switch to c++11 for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 Files: clang/include/clang/Analysis/FlowSensitive/Value.h

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 413673. ymandel added a comment. Add test for recursive type case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 Files: clang/include/clang/Analysis/FlowSensitive

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D121158#3365415 , @xazax.hun wrote: >> When pre-initializing fields in the environment, the code assumed that all >> fields of a struct would be initialized > > Was this assumption ever correct given that it was already skippi

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Thanks for the review! That was impressively fast... :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 ___ cfe-commits mailing list cf

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. > When pre-initializing fields in the environment, the code assumed that all > fields of a struct would be initialized Was this assumption ever correct given that it was already skipping the initialization of recursive cases? Repository: rG LLVM Github Monorepo C

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

2022-03-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: sgatev. Herald added subscribers: tschuett, steakhal. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. When pre-initializing fields in the environment, the code assumed that all fields of