[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 (LLVM bits) and 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added a comment. If there aren't additional review comments, I plan to land this tomorrow. Any comments that come in after that are ones I'm happy to address post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 _

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Would love someone to check out the APInt changes to confirm it is 'doing the right thing', but as far as I can tell it is right (and I'm just not confident enough to say so :D). CHA

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1156 + if (const auto *BT = Node->getType()->getAs()) { +OS << (isSigned ? "wb" : "uwb"); erichkeane wrote: > You don't need BT here anymore (sorry for missing that!). No worrie

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412509. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. getAs -> isa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1156 + if (const auto *BT = Node->getType()->getAs()) { +OS << (isSigned ? "wb" : "uwb"); You don't need BT here anymore (sorry for missing that!). CHANGES SINCE LAST ACTION ht

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman marked 5 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1157 + if (const auto *BT = Node->getType()->getAs()) { +OS << (BT->isUnsigned() ? "uwb" : "wb"); +return; erichkeane wrote: >

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412507. aaron.ballman added a comment. Correct a think-o that fixes a failing test. Also removed a newline that didn't need to exist. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/d

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:65 bool isLong : 1; // This is *not* set for long long. bool isLongLong : 1; bool isSizeT : 1; // 1z, 1uz (C++2b) aaron.ballman wrote: > erichkeane wr

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:65 bool isLong : 1; // This is *not* set for long long. bool isLongLong : 1; bool isSizeT : 1; // 1z, 1uz (C++2b) erichkeane wrote: > I can't help

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412502. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/docs/ReleaseNotes.rst

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane added a subscriber: craig.topper. erichkeane added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:65 bool isLong : 1; // This is *not* set for long long. bool isLongLong : 1; bool isSizeT : 1; // 1z, 1uz (C++2b)

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412248. aaron.ballman added a comment. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight, rjmccall, rsmith. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: l