Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

2015-08-14 Thread Martell Malone via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245076: Windows ARM: ignore calling conventions as described on MSDN (authored by martell). Changed prior to commit: http://reviews.llvm.org/D12034?vs=32164&id=32166#toc Repository: rL LLVM http://r

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

2015-08-14 Thread Martell Malone via cfe-commits
martell updated this revision to Diff 32164. martell added a comment. updated to reflect rnk comments http://reviews.llvm.org/D12034 Files: lib/Basic/Targets.cpp test/Parser/arm-windows-calling-convention-handling.c test/Parser/x64-windows-calling-convention-handling.c Index: test/Parser

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

2015-08-14 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: test/Parser/arm-windows-calling-convention-handling.c:2 @@ -1,3 @@ -// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only -verify %s - -int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling conv

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

2015-08-14 Thread Martell Malone via cfe-commits
martell added inline comments. Comment at: test/Parser/arm-windows-calling-convention-handling.c:2 @@ -1,3 @@ -// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only -verify %s - -int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling

Re: [PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

2015-08-14 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: test/Parser/arm-windows-calling-convention-handling.c:2 @@ -1,3 @@ -// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only -verify %s - -int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling conv

[PATCH] D12034: WindowsARM: ignore calling conventions as described on MSDN

2015-08-14 Thread Martell Malone via cfe-commits
martell created this revision. martell added a reviewer: rnk. martell added subscribers: compnerd, cfe-commits. Herald added subscribers: rengolin, aemerson. MSDN says that fastcall stdcall and thiscall and vectorcall are all accepted but ignored on ARM and X64 https://msdn.microsoft.com/en-us/l