[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. This commit caused following regression https://github.com/llvm/llvm-project/issues/57449#issuecomment-1232102039 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 ___

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. The ScudoCUnitTest-mips64el-Test failure looks like a mips64el specific issue. FAILED: lib/scudo/standalone/tests/ScudoCUnitTest-mips64el-Test cd /b/sanitizer-x86_64-linux-qemu/build/llvm_build2_debug_mips64el_qemu/lib/scudo/standalone/tests && /b/sanitizer-x86_64-

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

thakis added a comment. We're seeing the same problem here https://bugs.chromium.org/p/chromium/issues/detail?id=1314297&q=linux_upload_clang&can=2 Reverted in e22a60b1c898a760a73417fa225c2fbe0609a69f for now. Repository:

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Looks like this causes a relocation failure on this buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/7311 ld.lld: error: relocation R_MIPS_64 cannot be used against local symbol; recompile with -fPIC >>> defined in ScudoUnitTestsObjects.wrappers_cpp_test.

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. Herald added a subscriber: StephenFan. @nemanjai mentioned "All the issues I was seeing seem to have been resolved. I can build with CLANG_DEFAULT_PIE_ON_LINUX=on without any failing sanitizer or crt failures." Will recommit. And ppc64 bots have hopefully got better with

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. @xbolva00 I've removed your comment due to inappropriate language and tone. Please find a more constructive way to communicate your point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.or

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. Herald added a project: All. In D120305#3347191 , @MaskRay wrote: > In D120305#3347177 , @nikic wrote: > >> Yes, because you reverted the change for that one buildbot, of course it is >>

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. I've been looking into the compile-time regressions. The large regression on sqlite3 is due to differences in inlining behavior. The inlining cost model is slightly different for PIC builds, because GEPs that are based on a global and have a variable offset are no longer

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. I have reverted the buildbot configuration change as well: https://github.com/llvm/llvm-zorg/commit/c01d0787c4a11e40d0fed81b0df6841bebc16f7f Now that everything is back to the original state, we can discuss how to proceed. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

Meinersbur added a comment. This patch also caused https://github.com/llvm/llvm-project/issues/54082. I noticed due to the revert making the openmp-offload-cuda-project bot green again (https://lab.llvm.org/staging/#/builders/155/builds/2482) Repo

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444bd

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347194 , @MaskRay wrote: > In D120305#3347193 , @nikic wrote: > >> In D120305#3347192 , @tstellar >> wrote: >> >>> In D120305#3347177

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347193 , @nikic wrote: > In D120305#3347192 , @tstellar > wrote: > >> In D120305#3347177 , @nikic wrote: >> >>> Yes, because you reve

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. In D120305#3347192 , @tstellar wrote: > In D120305#3347177 , @nikic wrote: > >> Yes, because you reverted the change for that one buildbot, of course it is >> green now. You could have also

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347177 , @nikic wrote: > Yes, because you reverted the change for that one buildbot, of course it is > green now. You could have also made the buildbot green by disabling tests on > that bot. Or disabling sanitizers

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347177 , @nikic wrote: > Yes, because you reverted the change for that one buildbot, of course it is > green now. You could have also made the buildbot green by disabling tests on > that bot. Or disabling sanitizers

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347161 , @MaskRay wrote: > In D120305#3347160 , @nikic wrote: > >> @MaskRay Please revert the change and all dependent changes you have made. A >> revert is not a personal af

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Yes, because you reverted the change for that one buildbot, of course it is green now. You could have also made the buildbot green by disabling tests on that bot. Or disabling sanitizers on it. Doesn't change the fact that the configuration it was originally testing is st

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347150 , @tstellar wrote: > [...] > >>> It's not acceptable, because buildbots are meant to represent a specific >>> configuration that the buildbot owner cares about. Changing the buildbot >>> configuration makes t

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347160 , @nikic wrote: > @MaskRay Please revert the change and all dependent changes you have made. A > revert is not a personal affront to you. It's not a judgement that you or > your change are bad. It's a simple m

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. @MaskRay Please revert the change and all dependent changes you have made. A revert is not a personal affront to you. It's not a judgement that you or your change are bad. It's a simple matter of policy and standard procedure. There's a good chance that next week you'll g

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347152 , @tstellar wrote: > In D120305#3347151 , @xbolva00 > wrote: > Given that the bot does not have a high success rate (track record) for at least the past mont

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347151 , @xbolva00 wrote: >>> Given that the bot does not have a high success rate (track record) for at >>> least the past month, I am unsure I am supposed to revert my change. > > What is interesting that always th

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. >> Given that the bot does not have a high success rate (track record) for at >> least the past month, I am unsure I am supposed to revert my change. What is interesting that always the patch author is the person to be blamed even when there are situations where it is

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347148 , @MaskRay wrote: > In D120305#3347145 , @tstellar > wrote: > >> In D120305#3347143 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. https://lab.llvm.org/buildbot/#/builders/57 is green Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 ___ cfe-commits mailing list cfe-c

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347145 , @tstellar wrote: > In D120305#3347143 , @MaskRay wrote: > >> In D120305#3347142 , @tstellar >> wrote: >> >>> In D120305#3347

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347143 , @MaskRay wrote: > In D120305#3347142 , @tstellar > wrote: > >> In D120305#3347139 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347142 , @tstellar wrote: > In D120305#3347139 , @MaskRay wrote: > >> In D120305#3347109 , @tstellar >> wrote: >> >>> [...] >>> The i

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347139 , @MaskRay wrote: > In D120305#3347109 , @tstellar > wrote: > >> [...] >> The issue here has nothing to do with the technical merits of the patch or >> what the root

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347109 , @tstellar wrote: > [...] > The issue here has nothing to do with the technical merits of the patch or > what the root cause of the problem is. The policy for this project is that > if you commit a patch tha

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. >> error: Segmentation fault (core dumped) This happens quite often on these ppc bots - they are known for unstability and slow cycles. >> Open https://lab.llvm.org/buildbot/#/builders/57 , click "Success Rate" tab, >> the rate is lower compared to other bots recently

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347108 , @MaskRay wrote: > In D120305#3347103 , @tstellar > wrote: > >> In D120305#3347058 , @nemanjai >> wrote: >> >>> In D120305#

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347103 , @tstellar wrote: > In D120305#3347058 , @nemanjai > wrote: > >> In D120305#3346880 , @MaskRay >> wrote: >> >>> While I feel

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347058 , @nemanjai wrote: > In D120305#3346880 , @MaskRay wrote: > >> While I feel sorry for leaving clang-ppc64le-rhel red for some time and am >> willing to fix issues if I

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347058 , @nemanjai wrote: > > Statements like this seem to be at odds with this community's culture (or at > least the way I understand it). > As long as I have been a member of this community, the guidance for pa

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nemanjai added a comment. In D120305#3346880 , @MaskRay wrote: > While I feel sorry for leaving clang-ppc64le-rhel red for some time and am > willing to fix issues if I have access to a ppc64 machine (especially > compiler-rt ones that I care about), >

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3346947 , @tstellar wrote: > In D120305#3346880 , @MaskRay wrote: > >> In D120305#3346787 , @nemanjai >> wrote: >> >>> In D120305#3346

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3346880 , @MaskRay wrote: > In D120305#3346787 , @nemanjai > wrote: > >> In D120305#3346144 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3346787 , @nemanjai wrote: > In D120305#3346144 , @MaskRay wrote: > >> In D120305#3345978 , @MaskRay >> wrote: >> >>> In D120305#33458

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nemanjai added a comment. In D120305#3346144 , @MaskRay wrote: > In D120305#3345978 , @MaskRay wrote: > >> In D120305#3345810 , @RKSimon >> wrote: >> >>> @MaskRay The ppc

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3345978 , @MaskRay wrote: > In D120305#3345810 , @RKSimon wrote: > >> @MaskRay The ppc buildbots have been red since these patches - please can >> you take a look? https://lab.

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444b

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3345810 , @RKSimon wrote: > @MaskRay The ppc buildbots have been red since these patches - please can you > take a look? https://lab.llvm.org/buildbot/#/builders/57/builds/15454 Seems that ppc64 doesn't support lsan -

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

RKSimon added a comment. @MaskRay The ppc buildbots have been red since these patches - please can you take a look? https://lab.llvm.org/buildbot/#/builders/57/builds/15454 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444bd

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Hm, it looks like enabling PIE has a pretty big negative compile-time impact, with a 20% regression on sqlite3: http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444bdd0e1fbe0a96f6e09779&to=3c4ed02698afec021c6bca80740d1e58e3ee019e&stat=instructions Cod

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c4ed02698af: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D120305?v

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. I'll test both CLANG_DEFAULT_PIE_ON_LINUX=on and CLANG_DEFAULT_PIE_ON_LINUX=off, and then push. This is long undue. I did not change the default when CLANG_DEFAULT_PIE_ON_LINUX was added to avoid changes to release/14.x. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Been running with this for some time now (before we added the option). We should address the tests but they look sorted now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay updated this revision to Diff 411016. MaskRay marked an inline comment as done. MaskRay added a comment. Explain pie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 Files: clang/CMakeLists.txt

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337045 , @atanasyan wrote: > In D120305#3337019 , @MaskRay wrote: > >> @atanasyan A few mips test/Driver tests will fail. Wonder if you have time >> making them more portabl

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337019 , @MaskRay wrote: > @atanasyan A few mips test/Driver tests will fail. Wonder if you have time > making them more portable... Otherwise I'll just add `UNSUPPORTED: > default-pie-on-linux` to them. > > Fail

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:177 +* CMake ``-DCLANG_DEFAULT_PIE_ON_LINUX=ON`` is now the default. + This matches GCC installations on many Linux distros. it would be nice to explain what "pie" it is doing :)

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a subscriber: atanasyan. MaskRay added a comment. @atanasyan A few mips test/Driver tests will fail. Wonder if you have time making them more portable... Otherwise I'll just add `UNSUPPORTED: default-pie-on-linux` to them. Failed Tests (6): Clang :: Driver/hip-fpie-option.hi

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay created this revision. MaskRay added reviewers: foutrelis, sylvestre.ledru, thesamesam, tstellar. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Default the option introd