This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG34a7387986a6: [analyzer] Add more sources to Taint analysis
(authored by gamesh411).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
Please check the docs if they are still in sync with the content.
I think it looks great overall.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
gamesh411 updated this revision to Diff 411765.
gamesh411 added a comment.
fix readlinkat arg index
extend testcase for readlinkat
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120236/new/
https://reviews.llvm.org/D120236
Files:
clang/docs/analy
gamesh411 marked 3 inline comments as done.
gamesh411 added a comment.
readlinkat fix incoming
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120236/new/
https://reviews.llvm.org/D120236
___
cfe-commits m
gamesh411 updated this revision to Diff 411763.
gamesh411 added a comment.
Herald added a subscriber: manas.
add readlinkat
rename _IO_getc testcase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120236/new/
https://reviews.llvm.org/D120236
Files:
steakhal added a comment.
Fewer nits this time.
We are converging!
Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:559
+ {{"gethostname"}, TR::Source({{0}})},
+ {{"getnameinfo"}, TR::Source({{2, 4}})},
+ {{"getseuserbyname"}, TR::Source({{1,
gamesh411 added inline comments.
Comment at: clang/docs/analyzer/checkers.rst:2358
Default sources defined by ``GenericTaintChecker``:
-``fdopen``, ``fopen``, ``freopen``, ``getch``, ``getchar``,
``getchar_unlocked``, ``gets``, ``scanf``, ``socket``, ``wgetch``
+ ``_IO_getc``,
gamesh411 updated this revision to Diff 410747.
gamesh411 marked 9 inline comments as done.
gamesh411 added a comment.
- s/getcw/getwd
- add gets_s
- remove getopt variants
- add realinkat
- discuss getnameinfo?
- rename tests
- update getnameinfo
- comment on source/propagator discrepancy
- updat
steakhal added a comment.
The pre-merge checks failed due to an unrelated test case:
`Driver/hip-link-bundle-archive.hip` (on Windows); so I think we are good to go
on that part.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120236/new/
https://r