[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-28 Thread Endre Fülöp via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34a7387986a6: [analyzer] Add more sources to Taint analysis (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-28 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Please check the docs if they are still in sync with the content. I think it looks great overall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-28 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 411765. gamesh411 added a comment. fix readlinkat arg index extend testcase for readlinkat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 Files: clang/docs/analy

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-28 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 3 inline comments as done. gamesh411 added a comment. readlinkat fix incoming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 ___ cfe-commits m

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-28 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 411763. gamesh411 added a comment. Herald added a subscriber: manas. add readlinkat rename _IO_getc testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 Files:

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-23 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Fewer nits this time. We are converging! Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:559 + {{"gethostname"}, TR::Source({{0}})}, + {{"getnameinfo"}, TR::Source({{2, 4}})}, + {{"getseuserbyname"}, TR::Source({{1,

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-23 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2358 Default sources defined by ``GenericTaintChecker``: -``fdopen``, ``fopen``, ``freopen``, ``getch``, ``getchar``, ``getchar_unlocked``, ``gets``, ``scanf``, ``socket``, ``wgetch`` + ``_IO_getc``,

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-23 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 410747. gamesh411 marked 9 inline comments as done. gamesh411 added a comment. - s/getcw/getwd - add gets_s - remove getopt variants - add realinkat - discuss getnameinfo? - rename tests - update getnameinfo - comment on source/propagator discrepancy - updat

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

2022-02-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. The pre-merge checks failed due to an unrelated test case: `Driver/hip-link-bundle-archive.hip` (on Windows); so I think we are good to go on that part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://r