[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93893e60f0c: [AArch64] Default HBC/MOPS features in clang (authored by tyb0807). Herald added a subscriber: MaskRay. Herald added a project: All. R

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D120111#3351001 , @tmatheson wrote: > LGTM, please give @nickdesaulniers some time to respond though. I do agree > that iterating over the features repeatedly is less than ideal,

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, please give @nickdesaulniers some time to respond though. I do agree that iterating over the features repeatedly is less than ideal, but also that this patch is probably not the pl

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 updated this revision to Diff 412010. tyb0807 added a comment. Taking into account remarks from @tmatheson, I'm reverting my latest changes consisting in caching architecture feature into a variable, which makes the `getAArch64ArchFeaturesFrom*` interfaces more complicated. I'd propose we

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:269 success = getAArch64MicroArchFeaturesFromMcpu( -D, getAArch64TargetCPU(Args, Triple, A), Args, Features); +D, getAArch64TargetCPU(Args, Triple, A), Args, Features, AF)

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tmatheson requested changes to this revision. tmatheson added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:269 success = getAArch64MicroArchFeaturesFromMcpu( -D, getAArch64TargetCPU(Args, Tri

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:464-473 + const char *v8691OrLater[] = {"+v8.6a", "+v8.7a", "+v8.8a", + "+v9.1a", "+v9.2a", "+v9.3a"}; auto Pos = st

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 updated this revision to Diff 410225. tyb0807 added a comment. Cache architecture feature to avoid scanning the feature list over and over again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120111/new/ https://reviews.llvm.org/D120111 F

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:464-473 + const char *v8691OrLater[] = {"+v8.6a", "+v8.7a", "+v8.8a", + "+v9.1a", "+v9.2a", "+v9.3a"}; auto Pos = std::find_first_of(Features.begin(),

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 created this revision. Herald added a subscriber: kristof.beyls. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements minimum support in clang for default HBC/MOPS features on v8.8-a/v9.3-a or later architectures.