Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. This landed a long time ago as r246192. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commit

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Alright, let's hash it, then. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

On Thu, Aug 20, 2015 at 2:45 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aprantl added inline comments. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or no

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 @@ -163,1 +163,4 @@ +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should contain + ///< external references to a PCH or module. +

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Maybe this is missing the point, but a hash collision between module files with different formats should be highly unlikely because we add the module format into the hash. llvm::hash_code Hash = llvm::hash_combine(DirName.lower(), FileName.lower(),

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 2:15 PM, Richard Smith wrote: > > rsmith added a subscriber: rsmith. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should > contain > +

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

rsmith added a subscriber: rsmith. Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 @@ -163,1 +163,4 @@ +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should contain + ///< external references to a PCH or module

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 1:12 PM, David Blaikie wrote: > > > > On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl > wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository for this revision to rL LLVM. > > This patch adds a -gmodules option to the driver and a -d

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Ping. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl created this revision. aprantl added reviewers: dblaikie, echristo. aprantl added a subscriber: cfe-commits. aprantl set the repository for this revision to rL LLVM. This patch adds a -gmodules option to the driver and a -dwarf-ext-refs to cc1 to enable the use of external type references