[PATCH] D119476: Generalize and harmonize sub-expression traversal

aaron.ballman closed this revision. aaron.ballman added a comment. In D119476#3394189 , @kimgr wrote: > Thanks! Could you help me land it? Author: Kim Gräsman gmail.com>. I've commit on your behalf in 276d2143148fd1519af8eef124dabc41eabb1bb0

[PATCH] D119476: Generalize and harmonize sub-expression traversal

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D119476#3394189 , @kimgr wrote: > Thanks! Could you help me land it? Author: Kim Gräsman gmail.com>. Happy to! Repository: rG LL

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added a comment. Thanks! Could you help me land it? Author: Kim Gräsman . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 ___ cfe-commits mailing list cfe

[PATCH] D119476: Generalize and harmonize sub-expression traversal

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Sorry for the delay in reviewing this, but this looks correct to me. I don't think the precommit CI failures on Debian relate to your patch, either, so this LGTM Repository: rG

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added a comment. @aaron.ballman Friendly Monday ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added a comment. Herald added a project: All. Gentle weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 ___ cfe-commits mailing list cfe-commits@

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr updated this revision to Diff 411666. kimgr added a comment. Fix typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 Files: clang/lib/AST/Expr.cpp Index: clang/lib/AST/Expr.cpp

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added inline comments. Comment at: clang/lib/AST/Expr.cpp:1903 +// Skip over implicit nodes produced as part of semantic analysis. +// Designed for use with IgnoreExpreNodes. +Expr *ignoreImplicitSemaNodes(Expr *E) { Typo: IgnoreExpr*e*Nodes Repository:

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added a subscriber: aaron.ballman. kimgr added a comment. @aaron.ballman First refactor to generalize and harmonize `getSubExprAsWritten` and `getConversionFunction`. As mentioned in the commit message, this is strictly speaking a functional change, but it should have no visible effect.

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr created this revision. Herald added a subscriber: kristof.beyls. kimgr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CastExpr::getSubExprAsWritten and getConversionFunction used to have disparate implementations to traverse the sub-