Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-18 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245414: [OPENMP] Link libomp.lib on Windows (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D11932?vs=32275&id=32502#toc Repository: rL LLVM http://reviews.llvm.org/D11932 F

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-18 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm http://reviews.llvm.org/D11932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-17 Thread İsmail Dönmez via cfe-commits
ismail accepted this revision. ismail added a reviewer: ismail. ismail added a comment. This revision is now accepted and ready to land. Great work. Tested fine on Windows. Next step would be mapping /openmp flag to -fopenmp but I guess thats for another bug. http://reviews.llvm.org/D11932 _

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-17 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 32275. ABataev added a comment. Add path to libomp.lib. http://reviews.llvm.org/D11932 Files: lib/Driver/Tools.cpp test/OpenMP/linking.c Index: lib/Driver/Tools.cpp === --- lib/Driver/Tool

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-15 Thread İsmail Dönmez via cfe-commits
ismail added a comment. In http://reviews.llvm.org/D11932#225158, @hfinkel wrote: > What library path should be passed (where did you build the OpenMP runtime > library)? This is a default installation so the lib path is $PATH_TO_CLANG_EXE/../lib which in my case is C:\Program Files\LLVM\lib

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-15 Thread hfin...@anl.gov via cfe-commits
hfinkel added a subscriber: hfinkel. hfinkel added a comment. In http://reviews.llvm.org/D11932#222515, @ismail wrote: > Tests pass but, now when I tried to compile a file with -fopenmp I get: > > LINK: fatal error LNK1104: cannot open file 'libomp.lib' > > libomp.lib does exist in "C:\Program Fi

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-12 Thread İsmail Dönmez via cfe-commits
ismail added a comment. Tests pass but, now when I tried to compile a file with -fopenmp I get: LINK: fatal error LNK1104: cannot open file 'libomp.lib' libomp.lib does exist in "C:\Program Files\LLVM\lib" but I guess we need to pass the library path down to linker. http://reviews.llvm.org/D1

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-11 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 31792. ABataev added a comment. Test fix http://reviews.llvm.org/D11932 Files: lib/Driver/Tools.cpp test/OpenMP/linking.c Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp +++ lib/D

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-11 Thread İsmail Dönmez via cfe-commits
ismail added a comment. OpenMP/linking.c fails here with VS2015 (building with -DCLANG_DEFAULT_OPENMP_RUNTIME=libomp) Command 21 Stderr: C:\cygwin64\home\ismail\src\llvm\tools\clang\test\OpenMP\linking.c:75:24: error: expected string not found in input // CHECK-MSVC-LINK-64: "link.exe" ^ :1

[PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-11 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: chandlerc, rsmith. ABataev added a subscriber: cfe-commits. Adds libomp.lib for -fopenmp=libomp and libiomp5md.lib for -fopenmp=libiomp5 on Windows http://reviews.llvm.org/D11932 Files: lib/Driver/Tools.cpp test/OpenMP/linking.c Index