[PATCH] D118949: [HIP] Support code object v5

2022-02-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e4ef2e81e0: [HIP] Support code object v5 (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D118949: [HIP] Support code object v5

2022-02-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added a comment. Will revise as recommended when committing. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118949/new/ https://reviews.llvm.org/D118949 ___ cfe-commits mailing list cfe-c

[PATCH] D118949: [HIP] Support code object v5

2022-02-03 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few nits, LGTM in general. Comment at: clang/lib/Driver/ToolChains/ROCm.h:27 +struct DeviceLibABIVersion { + unsigned Value = 0; + DeviceLibABIVersion(unsigned V) : Value(V) {} -

[PATCH] D118949: [HIP] Support code object v5

2022-02-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: dang, kerbowa, jvesely. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. New device library supporting v4 and v5 has abi_version_400.bc a