[PATCH] D118652: Cleanup header dependencies in LLVMCore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe188aae406f3: Cleanup header dependencies in LLVMCore (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118652/new/ https://reviews.llvm.org/D118652 __

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille added a comment. In D118652#3286018 , @mehdi_amini wrote: > I'm not sure how it'd help clients of the released version of LLVM to delay, > the development branch and the release seems fairly disconnected to me from > this point of vie

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille added a comment. Hi and thanks for taking the time to go through the review. In D118652#3285601 , @MaskRay wrote: > Thanks for working on this. I spot checked some files. In general it looks > great. > > One file replaces a forward dec

[PATCH] D118652: Cleanup header dependencies in LLVMCore

mehdi_amini added a comment. I'm not sure how it'd help clients of the released version of LLVM to delay, the development branch and the release seems fairly disconnected to me from this point of view. (what can help are deprecating APIs with instructions about how to update so that they can up

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay added a comment. > It is very likely to break downstream code unless they took a lot of care in > avoiding hidden ehader dependencies, something the LLVM codebase doesn't do > that well :-/ release/14.x will branch soon. Will it be useful to deliberately miss the branch point so that d

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay added a comment. Thanks for working on this. I spot checked some files. In general it looks great. One file replaces a forward declaration with `#include "llvm/IR/BasicBlock.h"`. Some files add `#include "llvm/Support/ToolOutputFile.h"`. One files adds `class FunctionPass;` Would you mi

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, lenary, mehdi_amini, MaskRay. Herald added subscribers: jeroen.dobbelaere, ormris, foad, dexonsmith, wenlei, jdoerfert, kerbowa, pengfei, arphaman, steven_wu, hiraditya, nhaehnle, jvesely, arsenm. Herald added a