[PATCH] D118322: [clangd] Fix a selection tree crash for unmatched-bracket code.

2022-01-27 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb1686bfe8e: [clangd] Fix a selection tree crash for unmatched-bracket code. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D118322?vs=403516&id=403753#toc Repository: rG LL

[PATCH] D118322: [clangd] Fix a selection tree crash for unmatched-bracket code.

2022-01-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Wow, nice find! I'd argue the bug is probably rather in `TokenBuffer::expandedTokens(SourceRange)` that produced this span. The idea that it might *rarely* include the EOF token seems l

[PATCH] D118322: [clangd] Fix a selection tree crash for unmatched-bracket code.

2022-01-26 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/clangd/i