[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-02-06 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. Discussion on riscv-v-spec : https://github.com/riscv/riscv-v-spec/issues/723#issuecomment-922153867, although v-spec and isa-spec still not clearly describe that, but seems ISA folks prefer having those implication relationship between those zve* and v extensions.

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-27 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 403858. jacquesguan added a comment. Update code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118225/new/ https://reviews.llvm.org/D118225 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/CodeGen/R

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-26 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:747 // Could not implement Zve* extension and the V extension at the same time. - if (HasZve32x && HasV) + if (HasZve && HasV) return createStringError( craig.topper wrote:

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-26 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 403503. jacquesguan added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118225/new/ https://reviews.llvm.org/D118225 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Code

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-26 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added a comment. In D118225#3272071 , @eopXD wrote: > Not sure if this simplifies things. Users and the compiler can use the macro > `__riscv_v_elen` and `__riscv_v_elen_fp` to do things to the vector-related > target feature. > > Other tha

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-26 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:747 // Could not implement Zve* extension and the V extension at the same time. - if (HasZve32x && HasV) + if (HasZve && HasV) return createStringError( Now we need to che

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-26 Thread Yueh-Ting Chen via Phabricator via cfe-commits
eopXD added a comment. Not sure if this simplifies things. Users and the compiler can use the macro __riscv_v_elen and __riscv_v_elen_fp to do things to the vector-related target feature. Other than that I dont hold any strong objection to this refactoring. Repository: rG LLVM Github Monor

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

2022-01-26 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan created this revision. jacquesguan added reviewers: craig.topper, eopXD, asb, luismarques, frasercrmck, HsiangKai, khchen, benshi001. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, joce