[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

2022-01-26 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf85ee6d56a93: [NFC] [AST] Move isSameEntity into ASTContext (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

2022-01-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems fine to me, no reason it cannot live in ASTContext if it makes future code easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

2022-01-26 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan added a comment. I'm insufficiently confident to review this kind of code motion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118223/new/ https://reviews.llvm.org/D118223 ___ cfe-commits maili

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

2022-01-26 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, erichkeane. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Currently we are trying to implement the semantics of C++ Modules. A big