This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb88ca619d33b: [NFC][CodeGen] Use llvm::DenseMap for
DeferredDecls (authored by yurai007).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
yurai007 added a comment.
Thank you all for review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118169/new/
https://reviews.llvm.org/D118169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
serge-sans-paille accepted this revision.
serge-sans-paille added a comment.
No performance regression on my side either (but only minor gains).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118169/new/
https://reviews.llvm.org/D118169
___
serge-sans-paille added a comment.
The change looks fine to me. I've started a set of benchmark to make sure it
provides the expected speedup.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118169/new/
https://reviews.llvm.org/D118169
erichkeane accepted this revision.
erichkeane added a comment.
This looks fine to change, and seems like a slight compile timeimprovement.
It seems that the only thing we use this for is .find, .erase, and operator[],
all of which don't depend on iterator order, so this should not cause any
pro
aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.
https://llvm-compile-time-tracker.com/compare.php?from=c39d22d1968cf07e54b5816ba76dccef8acaace1&to=1958f5a5fb5be3fb5b6bad5079a2f3485db0b0e9&stat=instructions
mostly neutral but a tiny bit of
yurai007 created this revision.
yurai007 added reviewers: nikic, xbolva00, erichkeane, craig.topper, aeubanks,
Tyker.
Herald added a subscriber: pengfei.
yurai007 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
CodeGenModule::DeferredDecls
