[PATCH] D117994: [Clang] Implement multidimentional subscript operator

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit on your behalf in c1512250960bd247519a9f959ad4af202402dcc4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin added a comment. @erichkeane Thanks for the review! I had to rebase. I also updated the cxx_status page. @aaron.ballman If it looks good to you to, feel free to commit whenever you can. Thanks :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 406841. cor3ntin added a comment. - Rebase - Update cxx_status as we are now targetting clang 15 instead of 14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I spent some more time looking at this, and don't see anything suspicious, and since the others didn't have anything to say (AND it is early in the cycle), I think I'm OK accepting thi

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaAccess.cpp:1799 +R = SourceRange(ArgExprs.front()->getBeginLoc(), +ArgExprs.front()->getEndLoc()); + } erichkeane wrote: > So should the 'end' be `ArgExprs.back()->getEndLoc()

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402781. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Erich's feedback: A source range was only constructed from the first element Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402780. cor3ntin added a comment. Address Erich's feedback: A source range was only constructed from the first element Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

erichkeane added a comment. I don't have sufficient experience to approve this, but I DID look through it and found 1 suspicious thing. Comment at: clang/lib/Sema/SemaAccess.cpp:1799 +R = SourceRange(ArgExprs.front()->getBeginLoc(), +ArgExprs.front()->g

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402610. cor3ntin added a comment. Fix another typo in the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files: clang-tools-extra/clang-tidy/modern

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

aaron.ballman added reviewers: rsmith, erichkeane, rjmccall. aaron.ballman added a comment. I've not had the chance to review yet, but adding some more reviewers for better visibility (I've got WG14 meetings coming up so my availability is a bit limited at the moment). Repository: rG LLVM Gi

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402353. cor3ntin added a comment. Fix typos in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files: clang-tools-extra/clang-tidy/modernize/LoopCon

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402349. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin created this revision. Herald added a subscriber: carlosgalvezp. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, clang-tools-extra. Implement P2128R6 in C++23 mode. Unlike GCC's