[PATCH] D117854: [RISCV] Refactor Zve* extensions.

2022-01-21 Thread Yueh-Ting Chen via Phabricator via cfe-commits
eopXD added a comment. Maybe change the title to address more specifically of what this patch does? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 ___ cfe-comm

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

2022-01-21 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 402173. jacquesguan added a comment. Herald added a subscriber: jdoerfert. Fix test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/lib/Basi

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

2022-01-21 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added a comment. In D117854#3261659 , @craig.topper wrote: > In D117854#3261618 , @eopXD wrote: > >> A question that bothers me is that we need to specify a specific feature to >> enable the TARGET_B

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

2022-01-21 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 402166. jacquesguan added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.or