[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-23 Thread Jianjian Guan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba16e3c31f66: [RISCV] Decouple Zve* extensions and the V extension. (authored by jacquesguan). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-23 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 402401. jacquesguan added a comment. Rebase main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-23 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 ___

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-23 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 402385. jacquesguan added a comment. Herald added a subscriber: pcwang-thead. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/inclu

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-23 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:185 + bool hasVInstructionsF16() const { +return HasStdExtV || (HasStdExtZve32f && HasStdExtZfh); + } This should be `(HasStdExtV || HasStdExtZve32f) && HasStdExtZfh`. V

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-22 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 402188. jacquesguan added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-22 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3978 for (StringRef F : ReqFeatures) { -if (TI.hasFeature(F)) - continue; - -// If the feature is 64bit, alter the string so it will print better in -// the diagnostic. -if (F =

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-22 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan updated this revision to Diff 402184. jacquesguan added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3978 for (StringRef F : ReqFeatures) { -if (TI.hasFeature(F)) - continue; - -// If the feature is 64bit, alter the string so it will print better in -// the diagnostic. -if (F

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

2022-01-21 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added a comment. In D117854#3263206 , @eopXD wrote: > Maybe change the title to address more specifically of what this patch does? Done, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11