This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e17c9613f36: [AArch64] Add some missing strict FP vector
lowering (authored by john.brawn).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks for the changes. LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117795/new/
https://reviews.llvm.org/D117795
___
cfe-commits
john.brawn updated this revision to Diff 405213.
john.brawn added a comment.
Update based on review comments and adjust formatting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117795/new/
https://reviews.llvm.org/D117795
Files:
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
llvm
john.brawn planned changes to this revision.
john.brawn added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484
+ // of the vector comparison instructions.
+ setOperationAction(ISD::STRICT_FSETCCS, VT, Expand);
+ // FIXME: We could potentially m
dmgreen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484
+ // of the vector comparison instructions.
+ setOperationAction(ISD::STRICT_FSETCCS, VT, Expand);
+ // FIXME: We could potentially make use of the vector comparison instructions
--
john.brawn added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484
+ // of the vector comparison instructions.
+ setOperationAction(ISD::STRICT_FSETCCS, VT, Expand);
+ // FIXME: We could potentially make use of the vector comparison instructions
dmgreen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484
+ // of the vector comparison instructions.
+ setOperationAction(ISD::STRICT_FSETCCS, VT, Expand);
+ // FIXME: We could potentially make use of the vector comparison instructions
--
john.brawn updated this revision to Diff 403614.
john.brawn retitled this revision from "[AArch64] Fixes for strict FP vector
instructions" to "[AArch64] Add some missing strict FP vector lowering".
john.brawn edited the summary of this revision.
john.brawn added a comment.
The other parts of thi
