[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. owenpan marked an inline comment as done. Closed by commit rGc95afac89e00: [clang-format][NFC] Clean up tryMergeLessLess() (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D117759?vs=401579&id=4017

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM, at first my head was confused with First[-1] but I think its ok. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117759/new/ https://reviews.llvm.org/D117759 ___ cfe-

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117759/new/ https://reviews.llvm.org/D117759 ___ cfe-commits mailing list

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread Owen Pan via Phabricator via cfe-commits
owenpan requested review of this revision. owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:440-441 - if (First[2]->is(tok::less) || First[1]->isNot(tok::less) || - First[0]->isNot(tok::less) || Fou

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 401579. owenpan added a comment. Further cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117759/new/ https://reviews.llvm.org/D117759 Files: clang/lib/Format/FormatTokenLexer.cpp Index: clang/lib/Format/FormatTokenLexer.cpp =

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Format/FormatTokenLexer.cpp:440-441 - if (First[2]->is(tok::less) || First[1]->isNot(tok::less) || - First[0]->isNot(tok::less) || Fou

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

2022-01-20 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks, pjessesco. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo