[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-20 Thread Ben Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0be3da1fab5a: [RISCV] Add intrinsic for Zbt extension (authored by Chenbing.Zheng, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468 ___

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng marked 8 inline comments as done. Chenbing.Zheng added a comment. In D117468#3255546 , @craig.topper wrote: > In D117468#3253879 , > @Chenbing.Zheng wrote: > >> In D117468#3253493

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng updated this revision to Diff 401468. Chenbing.Zheng added a comment. modify tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468 Files: clang/include/clang/Basic/BuiltinsRISCV.def cla

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D117468#3253879 , @Chenbing.Zheng wrote: > In D117468#3253493 , @craig.topper > wrote: > >> Out of curiosity, what is your interest in Zbt? Do you work for a company >> that is

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rv32zbt-intrinsic.ll:21 +; RV32ZBT: # %bb.0: +; RV32ZBT-NEXT:fsr a0, a1, a0, a2 +; RV32ZBT-NEXT:ret This should have the same register order as the fsl test case. I think the te

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng added a comment. In D117468#3253493 , @craig.topper wrote: > Out of curiosity, what is your interest in Zbt? Do you work for a company > that is implementing this extension in hardware? My company has not implementing this extension,but

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-19 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng updated this revision to Diff 401124. Chenbing.Zheng added a comment. rebase main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468 Files: clang/include/clang/Basic/BuiltinsRISCV.def clan

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Out of curiosity, what is your interest in Zbt? Do you work for a company that is implementing this extension in hardware? Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4246 + case Intrinsic::riscv_fsl: +return DAG.getNode(RISCVISD:

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4246 + case Intrinsic::riscv_fsl: +return DAG.getNode(RISCVISD::FSL, DL, XLenVT, Op.getOperand(1), + Op.getOperand(2), Op.getOperand(3)); craig.

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4246 + case Intrinsic::riscv_fsl: +return DAG.getNode(RISCVISD::FSL, DL, XLenVT, Op.getOperand(1), + Op.getOperand(2), Op.getOperand(3)); The op

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:907 (FSR GPR:$rs1, GPR:$rs2, GPR:$rs3)>; +def : Pat<(riscv_fsr GPR:$rs3, GPR:$rs1, uimmlog2xlen:$shamt), + (FSRI GPR:$rs1, GPR:$rs3, uimmlog2xlen:$shamt)>; --

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-18 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng marked 2 inline comments as done. Chenbing.Zheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:907 (FSR GPR:$rs1, GPR:$rs2, GPR:$rs3)>; +def : Pat<(riscv_fsr GPR:$rs3, GPR:$rs1, uimmlog2xlen:$shamt), + (FSRI GPR:$r

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-18 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng updated this revision to Diff 400768. Chenbing.Zheng edited the summary of this revision. Chenbing.Zheng added a comment. del cmov,cmix,fsri in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.or

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-17 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:65 +// Zbt extension +TARGET_BUILTIN(__builtin_riscv_cmov, "LiLiLiLi", "nc", "experimental-zbt") +TARGET_BUILTIN(__builtin_riscv_cmix, "LiLiLiLi", "nc", "experimental-zbt") ---

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

2022-01-17 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng created this revision. Chenbing.Zheng added reviewers: craig.topper, LevyHsu, asb, benshi001. Chenbing.Zheng added a project: LLVM. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton