This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG560eb2277bb5: [clang-format] Fix bug in parsing
`operator<` with template (authored by pjessesco, committed by curdeius).
Changed prior to commit:
curdeius added a comment.
Or I'll add it when landing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117398/new/
https://reviews.llvm.org/D117398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
curdeius added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:9466
verifyFormat("operator SomeType>();");
+ verifyFormat("operator< <>();");
+ verifyFormat("< <>");
Looking at other related bug reports, I think that we should test `operat
pjessesco updated this revision to Diff 400782.
pjessesco added a comment.
Fix revision after running `git clang-format`.
Sorry for annoying, I thought I did not make any changes at that line. :(
name : Jino Park
email : pjesse...@gmail.com
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
owenpan added inline comments.
Comment at: clang/lib/Format/FormatTokenLexer.cpp:433-446
bool FourthTokenIsLess = false;
- if (Tokens.size() > 3)
-FourthTokenIsLess = (Tokens.end() - 4)[0]->is(tok::less);
- auto First = Tokens.end() - 3;
+ if (Tokens.size() > 3) {
+
MyDeveloperDay added a comment.
run git clang-format before submitting (if making the patch from staged files)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117398/new/
https://reviews.llvm.org/D117398
___
cfe-commits mailing list
cfe-commits
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added inline comments.
This revision now requires changes to proceed.
Comment at: clang/unittests/Format/FormatTest.cpp:9468
"typename ();");
verifyFormat("auto aa
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks for working on this!
Do you have commit rights or do you need that someone lands it for you?
If you need help, please indicate your name and email to be used for the commit.
A
pjessesco updated this revision to Diff 400697.
pjessesco marked 2 inline comments as done.
pjessesco added a comment.
Fix to accept feedbacks.
1. `Forth` -> `Fourth`
2. Add unit test `verifyFormat("< <>");`
3. Fix to avoid undefined behavior
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
curdeius added inline comments.
Comment at: clang/lib/Format/FormatTokenLexer.cpp:432
+ auto Forth = (Tokens.end() - 4)[0];
bool FourthTokenIsLess = false;
MyDeveloperDay wrote:
> isn't this going to crash if Tokens.size() is 3?
It probably will. Anyway, it
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/FormatTokenLexer.cpp:432
+ auto Forth = (Tokens.end() - 4)[0];
bool FourthTokenIsLess = false;
isn't this going to crash if Tokens.size() is 3?
Repository:
rG LLVM Github Monorepo
CHANG
pjessesco updated this revision to Diff 400341.
pjessesco added a comment.
Fix to pass unittest
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117398/new/
https://reviews.llvm.org/D117398
Files:
clang/lib/Format/FormatTokenLexer.cpp
clang/lib/Format/TokenAnnotator.cpp
clang/unitte
pjessesco updated this revision to Diff 400290.
pjessesco added a comment.
Add deleted newline in `FormatTest.cpp` by mistake
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117398/new/
https://reviews.llvm.org/D117398
Files:
clang/lib/Format/FormatTokenLexer.cpp
clang/lib/Format/Tok
pjessesco created this revision.
pjessesco requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
https://github.com/llvm/llvm-project/issues/44601
This patch handles a bug when parsing a below example code :
template class S;
template
14 matches
Mail list logo
