[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 closed this revision. fakepaper56 added a comment. Herald added subscribers: pcwang-thead, eopXD. The patch content is in D119727 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/ https://revi

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

achieveartificialintelligence accepted this revision. achieveartificialintelligence added a comment. This revision is now accepted and ready to land. OK, LGTM. Thanks! @fakepaper56 @khchen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/ h

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

khchen added a comment. > The main reason I want to add the prefix "llvm::" is all None in the files > are "llvm::None" form. It makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/ https://reviews.llvm.org/D117199 __

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 added a comment. The main reason I want to add the prefix "llvm::" is all None in the files are "llvm::None" form. But also it is more feasible when we want to add a variable name 'None' in the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

achieveartificialintelligence added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:300 if (Log2ScaleResult < 0) -return None; +return llvm::None; return 1 << Log2ScaleResult; We have used using namespace llvm; Repository: rG

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 created this revision. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,