[PATCH] D117137: [Driver] Add CUDA support for --offline param

yaxunl added a comment. The title says `--offline` option, which should be `--offload`. Comment at: clang/include/clang/Driver/Options.td:1142 def offload_EQ : CommaJoined<["--"], "offload=">, Flags<[NoXarchOption]>, - HelpText<"Specify comma-separated list of offloading targ

[PATCH] D117137: [Driver] Add CUDA support for --offline param

tra added a comment. LGTM in general, modulo few nits. Nit: looks like the changes need some clang-formatting. Comment at: clang/lib/Driver/Driver.cpp:112 default: - D.Diag(diag::err_drv_only_one_offload_target_supported_in) << "HIP"; + D.Diag(diag::err_drv_only_

[PATCH] D117137: [Driver] Add CUDA support for --offline param

dcastagna added a comment. In D117137#3238275 , @tra wrote: > I think instead of setting the triple directly from the command line, we > should start with adding another `--cuda-gpu-arch` (AKA --offload-arch) > variant and derive the triple and other p

[PATCH] D117137: [Driver] Add CUDA support for --offline param

dcastagna updated this revision to Diff 401461. dcastagna retitled this revision from "[Driver] Add a flag cuda-device-triple" to "[Driver] Add CUDA support for --offline param". dcastagna edited the summary of this revision. dcastagna added a comment. Using already existing --offload parameters