This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG64816e68f441: [AArch64] Support for Ampere1 core (authored
by philipp.tomsich, committed by dmgreen).
Repository:
rG LLVM Github Monorepo
CHANGES
philipp.tomsich updated this revision to Diff 426622.
philipp.tomsich marked 4 inline comments as done.
philipp.tomsich added a comment.
Rebased to main.
The earlier base-regression was a precommitted test-case that caused
SimpleLoopUnswitch tests (not related to these changes) to fail.
Reposit
philipp.tomsich updated this revision to Diff 426541.
philipp.tomsich added a comment.
Adds two fixes for issues uncovered by the CI:
- The update of NumAArch64CPUArchs had been lost in a "rebase gone wrong"
(i.e., another target was added and the previously increased-by-1 value now was
the alr
philipp.tomsich updated this revision to Diff 425726.
philipp.tomsich added a comment.
- additional tab -> space conversion (hopefully, I have emacs configured
correctly now)
- added SBSS and MTE to the SubtargetFeatures
- inserted AMpere1 in the subtarget enum in alphabetical order
Repository:
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
I don't know the details of the scheduling latencies for the core, but this
looks perfectly sensible. There are a few comments inline, but other than those
this patch LGTM.
==
philipp.tomsich updated this revision to Diff 425609.
philipp.tomsich added a comment.
Herald added a project: All.
Update to reflect review results.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117112/new/
https://reviews.llvm.org/D117112
Files:
dmgreen added a comment.
You could consider adding some scheduling tests, like those in
llvm/test/tools/llvm-mca/AArch64/Cortex/A55-basic-instructions.s. In the past
we have tended not to add them for schedules, so they are not necessary, but
can be useful for checking the details are as you ex
philipp.tomsich created this revision.
philipp.tomsich added reviewers: kristof.beyls, jgreenhalgh.
Herald added a subscriber: hiraditya.
philipp.tomsich requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Add support for the
