beanz accepted this revision.
beanz added a reviewer: beanz.
beanz added a comment.
This revision is now accepted and ready to land.
You are right, and I apparently don't know how to read documentation...
Patch LGTM as is.
http://reviews.llvm.org/D11682
__
EricWF added a comment.
@beanz I tested installing both libc++abi.so and libc++abi.a at the same time
with different destinations. They both installed into the correct destinations.
http://reviews.llvm.org/D11682
___
cfe-commits mailing list
cfe-co
EricWF added a comment.
What about the extra `[` at the beginning of `ARCHIVE` that spans all the way
down to the last line. It seems to me that `DESTINATION` can be supplied for
each library type. There is also an example in the docs that shows using two
library types in one install command.
beanz added a comment.
The signature is:
install(TARGETS targets... [EXPORT ]
[[ARCHIVE|LIBRARY|RUNTIME|FRAMEWORK|BUNDLE|
PRIVATE_HEADER|PUBLIC_HEADER|RESOURCE]
[DESTINATION ]
[INCLUDES DESTINATION [ ...]]
[PERMISSIONS permissions...]
EricWF added a comment.
Followup on @beanz comments.
Comment at: src/CMakeLists.txt:123
@@ -124,1 +122,3 @@
+ LIBRARY DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
+ ARCHIVE DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
)
bea
EricWF added a comment.
In http://reviews.llvm.org/D11682#216902, @jroelofs wrote:
> Does this install the headers too?
No. Just the libraries.
http://reviews.llvm.org/D11682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
