[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Elvis Stansvik via Phabricator via cfe-commits
estan added a comment. Ah thanks. Yea no worries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D116814#3235240 , @estan wrote: > BTW how are backports to release branches made in LLVM? (sorry if it's in the > docs somewhere!) We document the process here: https://llvm.org/docs/HowToReleaseLLVM.html#merge-request

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Elvis Stansvik via Phabricator via cfe-commits
estan added a comment. BTW how are backports to release branches made in LLVM? (sorry if it's in the docs somewhere!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 _

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Elvis Stansvik via Phabricator via cfe-commits
estan added a comment. 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I commit on your behalf in 36af07334246a87a0f3fb9bbc85dedfca04b00d1 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Elvis Stansvik via Phabricator via cfe-commits
estan added a comment. Ah right, `Elvis Stansvik ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D116814#3234768 , @estan wrote: > Thanks @aaron.ballman. I don't have commit/push rights, so someone please > commit for me when you got the time. Happy to! What name and email address would you like me to use for patch

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Elvis Stansvik via Phabricator via cfe-commits
estan added a comment. Thanks @aaron.ballman. I don't have commit/push rights, so someone please commit for me when you got the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 _

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

2022-01-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814