MaskRay accepted this revision.
MaskRay added a comment.
Looks great!
Thanks for telling me that GCC `overloads -fno-math-errno to mean that malloc
does not set errno`. This looks really scary. Clang doesn't have the problem:)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Verified with the docs from musl.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116753/new/
https://reviews.llvm.org/D116753
alxu added subscribers: MaskRay, pirama, srhines.
alxu added a comment.
Hi, can someone take a look at this? @MaskRay, @pirama, @srhines? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116753/new/
https://reviews.llvm.org/D116753
__
alxu created this revision.
alxu added a project: clang.
alxu requested review of this revision.
Herald added a subscriber: cfe-commits.
musl does not set errno in math functions:
https://wiki.musl-libc.org/mathematical-library.html,
https://github.com/ifduyue/musl/blob/cfdfd5ea3ce14c6abf7fb22a5