This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe7481f6ee591: [clang][dataflow] Add transfer functions for
assignment (authored by sgatev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
sgatev added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:36
+/// FIXME: Consider replacing this with a model that is more aligned with C++
+/// value categories.
+enum class SkipPast {
xazax.hun wrote:
> ymandel w
sgatev updated this revision to Diff 398629.
sgatev marked 8 inline comments as done.
sgatev added a comment.
Address reviewers' comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116596/new/
https://reviews.llvm.org/D116596
Files:
clang/in
xazax.hun added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:36
+/// FIXME: Consider replacing this with a model that is more aligned with C++
+/// value categories.
+enum class SkipPast {
ymandel wrote:
> I'm not
ymandel added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:36
+/// FIXME: Consider replacing this with a model that is more aligned with C++
+/// value categories.
+enum class SkipPast {
I'm not sure that value cat
sgatev added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:34
+/// storage locations or values.
+enum class SkipPast {
+ /// No indirections should be skipped past.
xazax.hun wrote:
> I am just wondering if this is
sgatev updated this revision to Diff 397508.
sgatev marked 3 inline comments as done.
sgatev added a comment.
Address reviewers' comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116596/new/
https://reviews.llvm.org/D116596
Files:
clang/in
xazax.hun added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:34
+/// storage locations or values.
+enum class SkipPast {
+ /// No indirections should be skipped past.
I am just wondering if this is the right level
sgatev updated this revision to Diff 397275.
sgatev added a comment.
Extend TransferTest.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116596/new/
https://reviews.llvm.org/D116596
Files:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalys
sgatev created this revision.
sgatev added reviewers: ymandel, xazax.hun, gribozavr2.
Herald added a subscriber: rnkovacs.
sgatev requested review of this revision.
Herald added a project: clang.
This is part of the implementation of the dataflow analysis framework.
See "[RFC] A dataflow analysis
10 matches
Mail list logo