This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8aea5d5951dc: [Arm] Remove duplicate CPU tests (authored by
tmatheson).
Changed prior to commit:
https://reviews.llvm.org/D116415?vs=396681&id=397
lenary accepted this revision.
lenary added a comment.
There is also a duplicate line (lines 29 and 31) of `// RUN: %clang -target arm
-march=armv5 -mthumb -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V5-THUMB
%s` which I think can be removed when you land this.
Repository:
rG LLVM Github
tmatheson added reviewers: lenary, dmgreen, cpirker, olista01, vsukharev,
SjoerdMeijer.
tmatheson added a comment.
Thanks for the review @nickdesaulniers. Adding a few more reviewers just to
check that I'm not missing something.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tmatheson added inline comments.
Comment at: clang/test/Driver/arm-cortex-cpus.c:217
// RUN: %clang -target arm -march=armv8.1-a -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-V81A %s
-// RUN: %clang -target arm -march=armv8.1a -mlittle-endian -### -c %s 2>&1 |
FileCheck -che
nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/Driver/arm-cortex-cpus.c:217
// RUN: %clang -target arm -march=armv8.1-a -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-V81A %
tmatheson created this revision.
Herald added a subscriber: kristof.beyls.
tmatheson requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
There are some duplicate test lines in clang/test/Driver/arm-cortex-cpus.c.
Looks like these were duplicate