aganea marked an inline comment as done.
aganea added inline comments.
Comment at: clang/lib/Driver/Job.cpp:390-392
Argv.push_back(nullptr);
+ Argv.pop_back(); // The terminating null element shall not be part of the
+ // slice (main() behavior).
---
aganea marked an inline comment as done.
aganea added inline comments.
Comment at: clang/lib/Driver/Job.cpp:390-392
Argv.push_back(nullptr);
+ Argv.pop_back(); // The terminating null element shall not be part of the
+ // slice (main() behavior).
---
aheejin added inline comments.
Comment at: clang/lib/Driver/Job.cpp:390-392
Argv.push_back(nullptr);
+ Argv.pop_back(); // The terminating null element shall not be part of the
+ // slice (main() behavior).
If we push `nullptr` and then pop
aganea added inline comments.
Comment at: clang/lib/Driver/Job.cpp:391
Argv.push_back(nullptr);
+ Argv.pop_back(); // The terminating null element shall not be part of the
+ // slice (main() behavior).
I changed this to match the behavior of
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd26520f6f787: [Clang] Own the CommandLineArgs in
CodeGenOptions (authored by aganea).
Changed prior to commit:
https://reviews.llvm.org/D116011?vs
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116011/new/
https://reviews.llvm.org/D116011
__
aganea created this revision.
aganea added reviewers: hans, aheejin, jansvoboda11.
Herald added a subscriber: dexonsmith.
aganea requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
As reported in PR52704: https://github.com/ll
