[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8179e1fd519d: [clang][dataflow] Add simplistic constant-propagation analysis. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 394617. ymandel marked 5 inline comments as done. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files: clang/unit

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp:145 +const BoundNodes &Nodes = Results[0]; +const ASTContext &Context = g

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked 10 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp:97 + +} // namespace + sgatev wrote: > Why not put the definitions below also in the anonymous names

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 394594. ymandel marked an inline comment as done. ymandel added a comment. Responds to reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files: cla

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. This demo looks cool. While I know this is a demo, I think it misses some important features, namely invalidating the value when we take the address of a variable or pass it to a function by non-const reference. I'm fine with not supporting those cases, but I'd love t

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp:69 + + friend bool operator==(ConstantPropagationLattice Element1, + ConstantPropagationLattice Element2) { Should this

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 394566. ymandel added a comment. Coalesce all CP files into one test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files: clang/unittests/Analysis/FlowSensi

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 394568. ymandel added a comment. updated file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files: clang/unittests/Analysis/FlowSensitive/CMakeLists.txt

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. Herald added a subscriber: mgorny. ymandel updated this revision to Diff 394325. ymandel added a comment. ymandel updated this revision to Diff 394417. ymandel updated this revision to Diff 394549. ymandel edited the summary of this revision. ymandel added reviewers: