[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

qiongsiwu1 added a comment. In D115670#3220052 , @erichkeane wrote: > Should be fixed here: 2edc21e8566be8fa9b20e0bb71a83af90ec9aa97 > > > Thanks! Thanks so much for the fix Erich! I

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Should be fixed here: 2edc21e8566be8fa9b20e0bb71a83af90ec9aa97 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llv

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Hi! Sorry for the delay, I just got back from my christmas break. I'll take a look later today/this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

qiongsiwu1 added subscribers: bmahjour, anhtuyen, qiongsiwu1. qiongsiwu1 added a comment. Hi everyone! We are encountering crashes in some of our `altivec` test cases due to this change. `clang` crashes when we have an instance of a `struct` or `union` type, and we assign the result of a unary o

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa94f68a2bd31: Implement some constexpr vector unary operators, fix boolean-ops (authored by erichkeane). Herald added a project: clang. Repository:

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Note: I think I've done everything requested, so I'm hoping to commit this tomorrow 1st thing in order to have it in time for everyone's vacations (and so my downstream can get it before the new year), unless I hear objections from the other reviewers. CHANGES SINC

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but I leave the final sign-off about the behavior to others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670 __

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane updated this revision to Diff 394604. erichkeane marked 7 inline comments as done. erichkeane added a comment. Fix Aaron+ Craig's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670 Files: clang/lib/AST/ExprConstant.cpp cl

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

craig.topper added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10188 +bool VisitUnaryOperator(const UnaryOperator *E); +// FIXME: Missing: unary ~, conditional operator (for GNU // conditional select), shufflevector, ExtVectorElementEx

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10188 +bool VisitUnaryOperator(const UnaryOperator *E); +// FIXME: Missing: unary ~, conditional operator (for GNU // conditional select), shufflevector, ExtVectorElementE

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane updated this revision to Diff 394599. erichkeane retitled this revision from "Correct behavior of Vector boolean-operations, implement vector operator-" to "Implement some constexpr vector unary operators, fix boolean-ops". erichkeane edited the summary of this revision. erichkeane add