This revision was automatically updated to reflect the committed changes.
Closed by commit rL246105: [Static Analyzer] Checks to catch nullability
related issues. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D11468?vs=33239&id=33267#toc
Repository:
rL LLVM
http://re
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good overall. I might have additional post-commit comments.
http://reviews.llvm.org/D11468
___
cfe-commits mailing list
cfe-commits@l
xazax.hun updated this revision to Diff 33239.
xazax.hun added a comment.
- Fine tuned the heuristics for cocoa APIs.
- Only track "nullable" and "contradicted" nullability for symbols. Use the
rest statically.
- Cleanups.
http://reviews.llvm.org/D11468
Files:
docs/analyzer/nullability.rst
xazax.hun updated this revision to Diff 33151.
xazax.hun marked 30 inline comments as done.
xazax.hun added a comment.
Addressed the comments.
Added some more tests.
Added a design document.
http://reviews.llvm.org/D11468
Files:
docs/analyzer/nullability.rst
lib/StaticAnalyzer/Checkers/CMak
zaks.anna added a comment.
Gabor, there is a lot of the same steps that all callbacks go through. I think
refactoring those into subroutines will help with readability of the checker.
Looking forward to seeing a new version soon!
Anna.
Comment at: lib/StaticAnalyzer/Checkers/N
zaks.anna added a comment.
Another partial review.
Thanks!
Anna.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:312
@@ +311,3 @@
+ CheckerContext &C) const {
+ auto RetExpr = S->getRetValue();
+ if (!RetExpr)
--
xazax.hun marked 11 inline comments as done.
xazax.hun added a comment.
Thank you for the review. I will upload the new version of the patch once the
rest of it was reviewed.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:12
@@ +11,3 @@
+// checker is that, the
zaks.anna added a comment.
Partial review...
Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:137
@@ +136,3 @@
+def NullPassedToNonnullChecker : Checker<"NullPassedToNonnull">,
+ HelpText<"Warns when a null pointer is passed to a nonnull pointer.">,
+ DescFile<"NullabilityC
xazax.hun updated this revision to Diff 32869.
xazax.hun added a comment.
- Updated to the latest trunk.
- Relaxed an assert in ExprEngine which turned out to be unsound.
- The individual checks can be turned on or off.
- Added some framework specific heuristic to reduce the number of false
posit
