[PATCH] D114665: [clangd] Make a.k.a printing configurable.

This revision was automatically updated to reflect the committed changes. lh123 marked 3 inline comments as done. Closed by commit rG6fe577b1c1e4: [clangd] Make a.k.a printing configurable. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114665?vs=391546&id=392648#toc R

Re: [PATCH] D114665: [clangd] Make a.k.a printing configurable.

SG if you also considered the style block. I suppose the risks of having this in a feature-specific block is much lower. On Tue, Dec 7, 2021, 20:14 Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added inline comments. > > > > Comment at: clang-tools-ext

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. kadircet wrote: > lh123 wrote: > > sammccall wrote: > > > One question is

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. lh123 wrote: > sammccall wrote: > > One question is whether the setting sh

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. sammccall wrote: > One question is wh

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Sorry about all the boilerplate for adding config, I think I should probably add some tablegen magic to cover everything except Config.h) Comment at: clang-tools-extr

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 391546. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114665/new/ https://reviews.llvm.org/D114665 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clangd/Con

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 390158. lh123 retitled this revision from "[clangd] Add a way to enable a.k.a print through config" to "[clangd] Make a.k.a printing configurable.". lh123 added a comment. fix testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https: