[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. With D114601 , this patch would no longer be needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114326/

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added a comment. In D114326#3159122 , @mojca wrote: > @tra: this is not yet 100% ready since the unit tests are now failing > (expecting to find CUDA 8.0). > I can fix the unit test, but I suppose that someone needs to install > additional SDK somew

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. @tra: this is not yet 100% ready since the unit tests are now failing (expecting to find CUDA 8.0). I can fix the unit test, but I suppose that someone needs to install additional SDK somewhere into the infrastructure as well? In D114326#3158913

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added a comment. In D114326#3154228 , @mojca wrote: > Somewhat off-topic from a discussion earlier in the thread. > What's the purpose of the following code then if users are supposed to > explicitly specify the `-L` flag anyway? Good point, it is i

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. @tra: what should be done about the unit test that checks whether CUDA SDK 8.0 specifically has been found? Apparently you are taking care of the buildbot configuration performing those tests. And how should we proceed in general, what can I do next? Thanks. Repository:

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp resigned from this revision. carlosgalvezp added a comment. This revision now requires review to proceed. I just learned that by approving this patch I make it not visible for other reviewers that they should still review, so I'll remove my vote. LGTM though. Repository: rG LLVM

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Somewhat off-topic from a discussion earlier in the thread. What's the purpose of the following code then if users are supposed to explicitly specify the `-L` flag anyway? c++ if (HostTriple.isArch64Bit() && FS.exists(InstallPath + "/lib64")) LibPath = Inst

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. I opened https://reviews.llvm.org/D114601. I wasn't sure if that's something that should have been combined with this ticket or not because it can be merged or rejected independently. I also opened a ticket for Microsoft STL on https://github.com/microsoft/STL/issues/235

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM but I think @tra should have the final word. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca updated this revision to Diff 389678. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114326/new/ https://reviews.llvm.org/D114326 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp ==

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; carlosgalve

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; m

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote:

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; carlosgal

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; m

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; mojca wrote

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; kadircet

[PATCH] D114326: Update the list of CUDA versions up to 11.5

kadircet added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; looks

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp added a comment. In D114326#3145187 , @mojca wrote: > And thanks to Carlos for accepting the patch. > > (In case it's not a super demanding task, I would be willing to invest a bit > of time towards making CUDA + Clang on Windows work bette

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. And thanks to Carlos for accepting the patch. (In case it's not a super demanding task, I would be willing to invest a bit of time towards making CUDA + Clang on Windows work better, but it would help to have "a supervisor" I could turn to when I get stuck or when I have

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Well, even after this patch neither `clang` nor `clangd` work correctly for me (I need some patches in llvm/clang sources, there are some issues with Microsoft's libraries; I wasn't able to make the linker work even after that), and CMake doesn't fully support CUDA + Clan

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Thanks for the fix! I'm surprised nobody complained about this until now, CUDA 8 is really old. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca created this revision. mojca added a reviewer: carlosgalvezp. mojca added a project: clang. Herald added subscribers: usaxena95, kadircet, yaxunl. mojca requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. I've been trying to address the following issue in