[PATCH] D114034: [clang-tidy] fix debug-only test failure

kbobyrev added a comment. In D114034#3141446 , @mattbeardsley wrote: > @dstenb Thanks for the confirmation! > > @kbobyrev Sorry about my mixup! Would you be able to help me commit this? Done! Thank you for the patch! Repository: rG LLVM Github Monor

[PATCH] D114034: [clang-tidy] fix debug-only test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG85e03cb7ebac: [clang-tidy] fix debug-only test failure (authored by mattbeardsley, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1140

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a comment. @dstenb Thanks for the confirmation! @kbobyrev Sorry about my mixup! Would you be able to help me commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114034/new/ https://reviews.llvm.org/D114034 _

[PATCH] D114034: [clang-tidy] fix debug-only test failure

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! I skimmed through the original patch and couldn't understand the `RenameFcn` part, thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley updated this revision to Diff 388329. mattbeardsley edited the summary of this revision. mattbeardsley added a comment. Well, I've goofed. I was working in a shared fork where someone added a RenameFcn check locally (not sure we should be doing that, but that's besides the point).

[PATCH] D114034: [clang-tidy] fix debug-only test failure

dstenb added a comment. In D114034#3136057 , @mattbeardsley wrote: > @dstenb - wanted to check with you too to make sure that this change to > pr37091.cpp seems like it won't interfere with the original intent of the > test (https://reviews.llvm.org/D4

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a subscriber: dstenb. mattbeardsley added a comment. @dstenb - wanted to check with you too to make sure that this change to pr37091.cpp seems like it won't interfere with the original intent of the test (https://reviews.llvm.org/D45686 ) The lingering file issue you'd fixed

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. The clang-tidy/infrastructure/pr37091.cpp