[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

This revision was automatically updated to reflect the committed changes. Closed by commit rG976a74d7d2db: [clangd] Dex Trigrams: Improve query trigram generation (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ http

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 392380. kbobyrev marked an inline comment as done. kbobyrev added a comment. No problem, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-to

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay! Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:46 // not available then 0 is stored. - std::vector> Next(LowercaseIdentifier.size

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390643. kbobyrev added a comment. Remove refactoring leftovers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.c

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390641. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:47 + const size_t NPOS = std::numeric_limits::max(); + llvm::SmallVector> Next(LowercaseIdentifier.size()); + size_t NextTail = NPOS, NextHead = NPOS; you've changed u

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:47 + const size_t NPOS = std::numeric_limits::max(); + llvm::SmallVector> Next(LowercaseIdentifier.size()); + size_t NextTail = NPOS, NextHead = NPOS; sammccall wrote:

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390627. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall added a comment. Basically LG now, some of the changes are a bit mysterious to me though Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:47 + const size_t NPOS = std::numeric_limits::max(); + llvm::SmallVector> Next(LowercaseIdentifier.size()); + size_t

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390298. kbobyrev added a comment. Slightly improve docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp cl

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390297. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:71 } - // Emit short-query trigrams: FooBar -> f, fo, fb. - if (!LowercaseIdentifier.empty()) -Out(Trigram(LowercaseIdentifier[0])); - if (LowercaseIdentifier.size() >= 2) -O

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 388461. kbobyrev added a comment. Add improvements for identifier trigram generation and make query & id generators consistent with each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https:/

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 387615. kbobyrev added a comment. Add a small comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp clan

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are the trigrams for quer