[PATCH] D113925: [HIP] Add HIP scope atomic operations

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_ne

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_ne

[PATCH] D113925: [HIP] Add HIP scope atomic operations

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs

[PATCH] D113925: [HIP] Add HIP scope atomic operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe13246a2ec3d: [HIP] Add HIP scope atomic operations (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D113925?vs=387668&id=3

[PATCH] D113925: [HIP] Add HIP scope atomic operations

yaxunl added a comment. In D113925#3141011 , @gandhi21299 wrote: > @yaxunl thanks for the review! My Github account is locked unfortunately so I > will have to ask you to push this commit to the main branch. Thank you! Sure. Repository: rG LLVM Git

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added a comment. @yaxunl thanks for the review! My Github account is locked unfortunately so I will have to ask you to push this commit to the main branch. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://re

[PATCH] D113925: [HIP] Add HIP scope atomic operations

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925 __

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387668. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - removed debug code - some macro definitions need to be defined for HIP-only compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D113925: [HIP] Add HIP scope atomic operations

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1347-1348 break; // Avoid crashing on code with undefined behavior +if (!OrderFail) + llvm::errs() << "FOO\n"; EmitAtomicOp(*this, E, Dest, Ptr, Val1, Val2, IsWeak, Order

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387396. gandhi21299 added a comment. reapplied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387395. gandhi21299 added a comment. clang-formatted code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925 Files: clang/include/clang/AST/Expr.h clang/include/

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 created this revision. gandhi21299 added reviewers: yaxunl, b-sumner, t-tye, tra, rjmccall. Herald added subscribers: dexonsmith, Anastasia. gandhi21299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an AtomicScopeModel for