[PATCH] D113896: [clangd] cleanup of header guard names

kadircet added a comment. > This looks to be a deliberate decision: > https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.h#L32 > > Looking at the code under `clang/include`, it looks like most headers don't > have the `#endif // COMMENT`, so this mi

[PATCH] D113896: [clangd] cleanup of header guard names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bd643d31d11: [clangd] cleanup of header guard names (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113896: [clangd] cleanup of header guard names

kbobyrev added a comment. Also, please mention the In D113896#3166732 , @kuhnel wrote: > @kadircet looks like clang-tidy does not detect missing comments in `#endif`. > It does complain about missing comments for namespaces. E.g. in > `Serialization.h`

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel added a comment. @kadircet looks like clang-tidy does not detect missing comments in `#endif`. It does complain about missing comments for namespaces. E.g. in `Serialization.h` the `#endif` comment is missing, but without a finding. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel updated this revision to Diff 391301. kuhnel marked 4 inline comments as done. kuhnel added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113896/new/ https://reviews.llvm.org/D113896 Files: clang-tools

[PATCH] D113896: [clangd] cleanup of header guard names

kadircet added a comment. LG apart from closing comments, some of the files have it and some don't (apart from the newly introduced ones, it didn't add it to the files that didn't have a closing comment, but updated the ones that had). The code from the tidy check looks like it should be handlin

[PATCH] D113896: [clangd] cleanup of header guard names

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.h:2 +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H + Please move the header guard after the comment like we do in the other

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.h:3 +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H + //===--- PathMapping.h - apply path mappings to LSP messages -===// Looks like the include guards were missing here. I suppo