[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Herald added a project: All. Abandoning this. We don't need to collect usage info from `-fimplicit-module-maps` because we don't use that feature during explicit builds: D120465 . Support for us

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:264 + if (Module || !AllowSearch || !HSOpts->ImplicitModuleMaps) { +noteModuleLookupUsage(Module, ImportLoc); return Module; ja

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 updated this revision to Diff 398146. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113676/new/ https://reviews.llvm.org/D113676 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/cla

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. I'm starting to think it could be fine to keep doing things as outlined by this patch: only marking search paths that discovered a module as used when its `Module` gets returned from `HeaderSearch` (and ignoring `Module

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:95 + if (HS.CurrentSearchPathIdx != ~0U) +HS.ModuleToSearchDirIdx[M] = HS.CurrentSearchPathIdx; +} ahoppen wrote: > Thes