carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.
Looks great, thanks! I'm not comfortable reviewing the Sema part, maybe someone
else can have a look?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113518/new/
https://
fwolff added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:374
{
PositiveSelfInitialization() : PositiveSelfInitialization() {}
};
carlosgalvezp wrote:
> fwolff wrote:
> > carlosgalvezp wr
fwolff updated this revision to Diff 386620.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113518/new/
https://reviews.llvm.org/D113518
Files:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp
clang/lib/Sema/SemaDeclCXX.cpp
Index: clang/lib/Sema/
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:374
{
PositiveSelfInitialization() : PositiveSelfInitialization() {}
};
fwolff wrote:
> carlosgalvezp wrote:
> > Not reall
fwolff marked 2 inline comments as done.
fwolff added a comment.
Thanks for your review @carlosgalvezp! I have addressed your inline comments.
I'm not sure about the failing test, but it looks like a regression test
internal to libFuzzer? Maybe it goes away with the rebuild.
fwolff updated this revision to Diff 386297.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113518/new/
https://reviews.llvm.org/D113518
Files:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp
clang/lib/Sema/SemaDeclCXX.cpp
Index: clang/lib/Sema
carlosgalvezp added a comment.
Also, what's with the pre-merge test, is it related?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113518/new/
https://reviews.llvm.org/D113518
___
cfe-commits mailing list
carlosgalvezp requested changes to this revision.
carlosgalvezp added a comment.
This revision now requires changes to proceed.
Amazing, thanks a lot for fixing this long-standing issue! I have a couple
comments. I'm not familiar at all with the Sema part so someone that knows
should look at it
fwolff created this revision.
fwolff added reviewers: rsmith, dblaikie, carlosgalvezp.
fwolff added a project: clang.
Herald added subscribers: kbarton, nemanjai.
fwolff requested review of this revision.
Herald added a subscriber: cfe-commits.
Herald added a project: clang-tools-extra.
This fixes
